I was thinking of implementing something like that.
Some general comments on your code:
I would like to have a -d or --duplicates parameter
The flag should make the search apply an additional filter to only find duplicates within the search result.
I dont think duplicating the search function is the way to go.
Ill check out the code in more detail later.
I was thinking of implementing something like that.
Some general comments on your code:
I would like to have a -d or --duplicates parameter
The flag should make the search apply an additional filter to only find duplicates within the search result.
I dont think duplicating the search function is the way to go.
Ill check out the code in more detail later.
Flamey
于 4 年前 修改标题 WIP: Add ability to find dulpicates 为 WIP: Add ability to find duplicates
The other thing that's important i found out is that we want to display results differently. I've been using it today to clean up and i really want 1 row per item/char.
The other thing that's important i found out is that we want to display results differently. I've been using it today to clean up and i really want 1 row per item/char.
Prism Powder/Flaahmie: Inventory(12), Mog Safe(3)
Prism Powder/Flamey: Satchel(3), Case(15)
Silent Oil/Flamey: Case(1), Sack(1)
After some more contemplating it makes sense to have a command like /findall_duplicates to show all duplicates and not only a subset by searching for characters or items. But I dont think it should integrate with the default search at all.
I would also only show stackable items.
I agree with you about the need to display results differently.
But this is findall it searches on all characters and the search results should reflect that.
After some more contemplating it makes sense to have a command like /findall_duplicates to show all duplicates and not only a subset by searching for characters or items. But I dont think it should integrate with the default search at all.
I would also only show stackable items.
I agree with you about the need to display results differently.
But this is findall it searches on all characters and the search results should reflect that.
Yeah i think it would need more work, but i do like seeing that i have darksteel ore scattered over 3 characters.
I think the main thing for duplicates is rearranging the output, default filtering to only stackable items.
I think an option to ignore complete stacks would be nice too.
Duplicates would be nice to default to current char, but multi char find is super useful.
Yeah i think it would need more work, but i do like seeing that i have darksteel ore scattered over 3 characters.
I think the main thing for duplicates is rearranging the output, default filtering to only stackable items.
I think an option to ignore complete stacks would be nice too.
Duplicates would be nice to default to current char, but multi char find is super useful.
I am quite scattered and probably losing 10-15 slots from stacks being split among inventories. Finds them all.
I was thinking of implementing something like that.
Some general comments on your code:
I would like to have a -d or --duplicates parameter
The flag should make the search apply an additional filter to only find duplicates within the search result.
I dont think duplicating the search function is the way to go.
Ill check out the code in more detail later.
WIP: Add ability to find dulpicates为 WIP: Add ability to find duplicatesThe other thing that's important i found out is that we want to display results differently. I've been using it today to clean up and i really want 1 row per item/char.
Prism Powder/Flaahmie: Inventory(12), Mog Safe(3)
Prism Powder/Flamey: Satchel(3), Case(15)
Silent Oil/Flamey: Case(1), Sack(1)
Oh and I see options for ignoring complete stacks, ignoring equippable gear.
After some more contemplating it makes sense to have a command like /findall_duplicates to show all duplicates and not only a subset by searching for characters or items. But I dont think it should integrate with the default search at all.
I would also only show stackable items.
I agree with you about the need to display results differently.
But this is findall it searches on all characters and the search results should reflect that.
Yeah i think it would need more work, but i do like seeing that i have darksteel ore scattered over 3 characters.
I think the main thing for duplicates is rearranging the output, default filtering to only stackable items.
I think an option to ignore complete stacks would be nice too.
Duplicates would be nice to default to current char, but multi char find is super useful.
Hi,
I implemented a duplicate and stackable search in the addon.
Care to try it?
Going to close this as it has been addressed fully in another pull request that has been merged.