WIP: Add ability to find duplicates #4

Закрыто
Flamey хочет смерджить 2 коммит(ов) из Flamey/findall:master в master
Flamey прокомментировал(а) 4 лет назад

I am quite scattered and probably losing 10-15 slots from stacks being split among inventories. Finds them all.

I am quite scattered and probably losing 10-15 slots from stacks being split among inventories. Finds them all.
Yunamahoutsukai прокомментировал(а) 4 лет назад

I was thinking of implementing something like that.

Some general comments on your code:
I would like to have a -d or --duplicates parameter

The flag should make the search apply an additional filter to only find duplicates within the search result.

I dont think duplicating the search function is the way to go.

Ill check out the code in more detail later.

I was thinking of implementing something like that. Some general comments on your code: I would like to have a -d or --duplicates parameter The flag should make the search apply an additional filter to only find duplicates within the search result. I dont think duplicating the search function is the way to go. Ill check out the code in more detail later.
Flamey изменил(а) заголовок с WIP: Add ability to find dulpicates на WIP: Add ability to find duplicates 4 лет назад
Flamey прокомментировал(а) 4 лет назад
Автор

The other thing that's important i found out is that we want to display results differently. I've been using it today to clean up and i really want 1 row per item/char.

Prism Powder/Flaahmie: Inventory(12), Mog Safe(3)
Prism Powder/Flamey: Satchel(3), Case(15)
Silent Oil/Flamey: Case(1), Sack(1)

The other thing that's important i found out is that we want to display results differently. I've been using it today to clean up and i really want 1 row per item/char. Prism Powder/Flaahmie: Inventory(12), Mog Safe(3) Prism Powder/Flamey: Satchel(3), Case(15) Silent Oil/Flamey: Case(1), Sack(1)
Flamey прокомментировал(а) 4 лет назад
Автор

Oh and I see options for ignoring complete stacks, ignoring equippable gear.

Oh and I see options for ignoring complete stacks, ignoring equippable gear.
Yunamahoutsukai прокомментировал(а) 4 лет назад

After some more contemplating it makes sense to have a command like /findall_duplicates to show all duplicates and not only a subset by searching for characters or items. But I dont think it should integrate with the default search at all.
I would also only show stackable items.
I agree with you about the need to display results differently.
But this is findall it searches on all characters and the search results should reflect that.

After some more contemplating it makes sense to have a command like /findall_duplicates to show all duplicates and not only a subset by searching for characters or items. But I dont think it should integrate with the default search at all. I would also only show stackable items. I agree with you about the need to display results differently. But this is findall it searches on all characters and the search results should reflect that.
Flamey прокомментировал(а) 4 лет назад
Автор

Yeah i think it would need more work, but i do like seeing that i have darksteel ore scattered over 3 characters.

I think the main thing for duplicates is rearranging the output, default filtering to only stackable items.

I think an option to ignore complete stacks would be nice too.
Duplicates would be nice to default to current char, but multi char find is super useful.

Yeah i think it would need more work, but i do like seeing that i have darksteel ore scattered over 3 characters. I think the main thing for duplicates is rearranging the output, default filtering to only stackable items. I think an option to ignore complete stacks would be nice too. Duplicates would be nice to default to current char, but multi char find is super useful.
Yunamahoutsukai прокомментировал(а) 4 лет назад

Hi,
I implemented a duplicate and stackable search in the addon.
Care to try it?

Hi, I implemented a duplicate and stackable search in the addon. Care to try it?
atom0s прокомментировал(а) 4 лет назад
Владелец

Going to close this as it has been addressed fully in another pull request that has been merged.

Going to close this as it has been addressed fully in another pull request that has been merged.
atom0s закрыл этот запрос на слияние 4 лет назад
Пожалуйста, переоткройте этот запрос на слияние для выполнения слияния.
Войдите, чтобы присоединиться к обсуждению.
Нет рецензентов
Нет меток
Нет этапа
Нет назначенных лиц
3 участников
Уведомления
Срок выполнения

Срок выполнения не установлен.

Зависимости

Этот запрос на слияние в настоящее время не имеет никаких зависимостей.

Загрузка…
Пока нет содержимого.