WIP: Changed os.time to os.clock #1

Open
Tornac wants to merge 1 commits from Tornac/blusets:master into master
Tornac commented 4 years ago

Reused some this code for the pupatt addon that Towbes and I worked on. Found out that os.time appears to go down to the second. os.clock appears to use fractions of seconds and will enable the packet delay variable to work as intended. untested with blu, tested with the reused code in pupatt. Apologies if i should have brought this up differently.

Reused some this code for the pupatt addon that Towbes and I worked on. Found out that os.time appears to go down to the second. os.clock appears to use fractions of seconds and will enable the packet delay variable to work as intended. untested with blu, tested with the reused code in pupatt. Apologies if i should have brought this up differently.
Owner

Before this can be merged in, would need someone to test it to verify it does not break the current setup/delay being used. Switching to os.clock is fine, but it will cause the delay to be more accurate instead of being rounded up like os.time would cause. (ie. the 0.65 would be actually handled as just 1 second instead before).

This will cause packets to be sent faster, so the delay may be too low now due to it. The default delay could be increased to 1 in general, but would opt. for confirmation that it doesn't break anything (ideally both on retail and p.server).

Before this can be merged in, would need someone to test it to verify it does not break the current setup/delay being used. Switching to os.clock is fine, but it will cause the delay to be more accurate instead of being rounded up like os.time would cause. (ie. the 0.65 would be actually handled as just 1 second instead before). This will cause packets to be sent faster, so the delay may be too low now due to it. The default delay could be increased to 1 in general, but would opt. for confirmation that it doesn't break anything (ideally both on retail and p.server).
This pull request is marked as a work in progress.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.